Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add examples and fix the dependency problem #13620

Merged
merged 3 commits into from
Jan 4, 2019
Merged

add examples and fix the dependency problem #13620

merged 3 commits into from
Jan 4, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Dec 12, 2018 •
edited
Loading

Description

Add a use case in the java demo explaining the usage of ParamObject
@andrewfayres @zachgk @piyushghai @nswamy

I am also getting tired of fixing the issue of the script (TODO):

  • Add CI test for the demo script for Java

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 changed the title [WIP] add examples and fix the dependency problem add examples and fix the dependency problem Dec 13, 2018
@lanking520
Copy link
Member Author

Now put this java-demo in the nightly test @marcoabreu please take a look

piyushghai
piyushghai reviewed Dec 13, 2018
View reviewed changes
scala-package/mxnet-demo/java-demo/Makefile
@@ -16,7 +16,7 @@
# under the License.

SCALA_VERSION_PROFILE := 2.11
MXNET_VERSION := 1.4.0-SNAPSHOT
MXNET_VERSION := [1.4.0-SNAPSHOT,\)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the minimum version to 1.5.0 ? Since the master is now at 1.5.0 and we are pushing out nightly snapshots with that version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the version here would grab the Lastest package that have version 1.4.0-SNAPSHOT or above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

piyushghai
piyushghai approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
I just have a minor comment, otherwise looks good.
This will definitely help us test out the nightly jars

@roywei
Copy link
Member

roywei commented Dec 14, 2018

@mxnet-label-bot add[Scala, CI]

@sandeep-krishnamurthy
Copy link
Contributor

@marcoabreu / @andrewfayres - Can you please help review this PR? Thanks

@lanking520
Copy link
Member Author

@zachgk could you please review

@lanking520 lanking520 merged commit e9a7aa4 into apache:master Jan 4, 2019
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
@lanking520
add examples and fix the dependency problem (apache#13620)
851e32a 
* add examples and fix the dependency problem

* add Nightly run and optimized script

* add explanation for the line
@lanking520 lanking520 deleted the fixDemo branch March 11, 2019 22:29
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@lanking520
add examples and fix the dependency problem (apache#13620)
307c8a1 
* add examples and fix the dependency problem

* add Nightly run and optimized script

* add explanation for the line
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piyushghai piyushghai piyushghai approved these changes

@zachgk zachgk zachgk approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
CI Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lanking520 @roywei @sandeep-krishnamurthy @zachgk @piyushghai @marcoabreu